support reset photon at fork #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
yuchen0cc
force-pushed
the
release/0.7
branch
from
3c2c6e5
to
3090204
Compare
yuchen0cc
force-pushed
the
release/0.7
branch
from
3090204
to
a24cd48
Compare
lihuiba
reviewed
Dec 4, 2023
io/reset_handle.cpp
Outdated
|
|
||
| namespace photon { | ||
|
|
||
| static ResetHandle *&ree_list() { |
There was a problem hiding this comment.
it seems no need to hide the list inside a function
There was a problem hiding this comment.
outter function has been removed.
io/reset_handle.cpp
Outdated
| namespace photon { | ||
|
|
||
| static ResetHandle *&ree_list() { | ||
| static thread_local ResetHandle *list = nullptr; |
There was a problem hiding this comment.
better use intrusive_list<ResetHandle> list;
There was a problem hiding this comment.
using pointer is meant to avoid construct/destruct.
io/reset_handle.cpp
Outdated
| } | ||
|
|
||
| void reset_all_handle() { | ||
| if (ree_list() == nullptr) |
There was a problem hiding this comment.
will be no need to handle nullptr, when using intrusive_list<ResetHandle>
| thread_yield(); // give a chance let eloop to execute do_wait | ||
| pthread_atfork(nullptr, nullptr, &fork_hook_child); | ||
| if (reset_handler == nullptr) { | ||
| reset_handler = new SignalResetHandle(); |
There was a problem hiding this comment.
better hide a handler object inside a function, rather than new one
| @@ -240,6 +254,10 @@ int libcurl_init(long flags, long pipelining, long maxconn) { | |||
|
|
|||
| libcurl_set_pipelining(pipelining); | |||
| libcurl_set_maxconnects(maxconn); | |||
| if (reset_handler == nullptr) { | |||
| reset_handler = new CurlResetHandle(); | |||
There was a problem hiding this comment.
better hide the handlers inside a function
| return 0; | ||
| } | ||
| }; | ||
| static thread_local CurlResetHandle *reset_handler = nullptr; |
There was a problem hiding this comment.
better hide the handlers inside a function like this:
static CurlResetHandle* get_reset_handler() {
static thread_local unique_ptr<CurlResetHandle> handler { new CurlResetHandle};
return handler.get();
}And there's no need to destruct it explicitly.
The same for aio, etc.
In photon context, event engine based module need reset after fork, if exec will not be called after fork. This is implicitly done by pthread_atfork hook. Signed-off-by: yuchen.cc <yuchen.cc@alibaba-inc.com>
yuchen0cc
force-pushed
the
release/0.7
branch
from
a24cd48
to
882db3f
Compare
lihuiba
approved these changes
Dec 6, 2023
lihuiba
pushed a commit
that referenced
this pull request
Dec 6, 2023
* Mute an UBSan check error for SCOPED_LOCK macro (#283) * io: support reset photon at fork (#282) In photon context, event engine based module need reset after fork, if exec will not be called after fork. This is implicitly done by pthread_atfork hook. Signed-off-by: yuchen.cc <yuchen.cc@alibaba-inc.com> --------- Signed-off-by: yuchen.cc <yuchen.cc@alibaba-inc.com> Co-authored-by: Bob Chen <beef9999@qq.com> Co-authored-by: yuchen0cc <91253032+yuchen0cc@users.noreply.github.com>
lihuiba
pushed a commit
that referenced
this pull request
Dec 12, 2023
* Mute an UBSan check error for SCOPED_LOCK macro (#283) * io: support reset photon at fork (#282) In photon context, event engine based module need reset after fork, if exec will not be called after fork. This is implicitly done by pthread_atfork hook. Signed-off-by: yuchen.cc <yuchen.cc@alibaba-inc.com> * RPC support graceful shutdown --------- Signed-off-by: yuchen.cc <yuchen.cc@alibaba-inc.com> Co-authored-by: Bob Chen <beef9999@qq.com> Co-authored-by: yuchen0cc <91253032+yuchen0cc@users.noreply.github.com>
lihuiba
added a commit
that referenced
this pull request
Dec 16, 2023
* Mute an UBSan check error for SCOPED_LOCK macro (#283) * io: support reset photon at fork (#282) In photon context, event engine based module need reset after fork, if exec will not be called after fork. This is implicitly done by pthread_atfork hook. Signed-off-by: yuchen.cc <yuchen.cc@alibaba-inc.com> * RPC support graceful shutdown * fs: support xattr for extfs and subfs (#298) Signed-off-by: yuchen.cc <yuchen.cc@alibaba-inc.com> * Sequential mutex (#294) seq_mutex * exit(0) requires stdlib.h (#303) * fix e2fs include dir name (#301) Signed-off-by: yuchen.cc <yuchen.cc@alibaba-inc.com> * [feat] http client with cert Signed-off-by: zhuangbowei.zbw <zhuangbowei.zbw@alibaba-inc.com> --------- Signed-off-by: yuchen.cc <yuchen.cc@alibaba-inc.com> Signed-off-by: zhuangbowei.zbw <zhuangbowei.zbw@alibaba-inc.com> Co-authored-by: Bob Chen <beef9999@qq.com> Co-authored-by: yuchen0cc <91253032+yuchen0cc@users.noreply.github.com> Co-authored-by: Huiba Li <lihuiba@gmail.com> Co-authored-by: zhuangbowei.zbw <zhuangbowei.zbw@alibaba-inc.com> Co-authored-by: Lanzheng Liu <lanzheng.liulz@alibaba-inc.com>
lihuiba
added a commit
that referenced
this pull request
Dec 18, 2023
* Mute an UBSan check error for SCOPED_LOCK macro (#283) * io: support reset photon at fork (#282) In photon context, event engine based module need reset after fork, if exec will not be called after fork. This is implicitly done by pthread_atfork hook. Signed-off-by: yuchen.cc <yuchen.cc@alibaba-inc.com> * RPC support graceful shutdown * fs: support xattr for extfs and subfs (#298) Signed-off-by: yuchen.cc <yuchen.cc@alibaba-inc.com> * Sequential mutex (#294) seq_mutex * exit(0) requires stdlib.h (#303) * fix e2fs include dir name (#301) Signed-off-by: yuchen.cc <yuchen.cc@alibaba-inc.com> * [feat] http client with cert Signed-off-by: zhuangbowei.zbw <zhuangbowei.zbw@alibaba-inc.com> * minor fix for std-compat (#307) * minor fix for std-compat * rpc::string add empty method * set io_uring eventfd non-blocking --------- Signed-off-by: yuchen.cc <yuchen.cc@alibaba-inc.com> Signed-off-by: zhuangbowei.zbw <zhuangbowei.zbw@alibaba-inc.com> Co-authored-by: Bob Chen <beef9999@qq.com> Co-authored-by: yuchen0cc <91253032+yuchen0cc@users.noreply.github.com> Co-authored-by: Huiba Li <lihuiba@gmail.com> Co-authored-by: zhuangbowei.zbw <zhuangbowei.zbw@alibaba-inc.com> Co-authored-by: Lanzheng Liu <lanzheng.liulz@alibaba-inc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In photon context, event engine based module need reset after fork, if exec will not be called after fork.
This is implicitly done by pthread_atfork hook.