Inlined defer #311
Merged
Inlined defer #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lihuiba
force-pushed
the
inlined_defer
branch
from
11b5323
to
b470ea9
Compare
beef9999
reviewed
Dec 21, 2023
| @@ -74,25 +74,25 @@ ptr_array_t<T> ptr_array(T* pbegin, size_t n) | |||
| return {pbegin, pbegin + n}; | |||
| } | |||
|
|
|||
| #define __INLINE__ __attribute__((always_inline)) | |||
| #define __FORCE_INLINE__ __INLINE__ inline | |||
|
|
|||
There was a problem hiding this comment.
Just wondering why force incline doesn't equal to always inline ...
There was a problem hiding this comment.
Plain functions need the inline keyword, otherwise the compiler will generates warnings. Whereas lambdas can not have inline. So we have to have 2 macros. Maybe the wording can be improved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make DEFER() always inline