Fix potential connection leak bug when closing NacosDataSource (#2962)

alibaba · Jan 5, 2023 · a63fea3 · a63fea3
1 parent f872864
commit a63fea3
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/...source-nacos/src/main/java/com/alibaba/csp/sentinel/datasource/nacos/NacosDataSource.java b/...source-nacos/src/main/java/com/alibaba/csp/sentinel/datasource/nacos/NacosDataSource.java
@@ -145,6 +145,12 @@ public String readSource() throws Exception {
     public void close() {
         if (configService != null) {
             configService.removeListener(dataId, groupId, configListener);
+            try {
+                configService.shutDown();
+            } catch (Exception e) {
+                RecordLog.warn("[NacosDataSource] Error occurred when closing Nacos data source", e);
+                e.printStackTrace();
+            }
         }
         pool.shutdownNow();
     }