Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support registering writable data-source for GatewayFlowRule and customized ApiDefinition #992

Closed
fuzhanwei opened this issue Aug 15, 2019 · 6 comments · Fixed by #1057
Closed
Labels
area/gateway-flow-control Issues or PRs related to API gateway flow control area/integrations Issues or PRs related to integrations with open-source components good first issue Good for newcomers kind/enhancement Category issues or prs related to enhancement.

Comments

@fuzhanwei
Copy link

WritableDataSourceRegistry 和 GatewayRuleManager不支持GatewayFlowRule注册写数据源

@sentinel-bot
Copy link
Collaborator

Hi @fuzhanwei, we detect non-English characters in the issue. This comment is an auto translation from @sentinel-bot to help other users to understand this issue.
We encourage you to describe your issue in English which is more friendly to other users.

Gateway mode traffic limiting rule GatewayFlowRule does not support extended registration write data source

WritableDataSourceRegistry and GatewayRuleManager do not support GatewayFlowRule registration write data source

@sentinel-bot sentinel-bot changed the title 网关模式的 限流规则 GatewayFlowRule 不支持扩展注册写数据源 Gateway mode traffic limiting rule GatewayFlowRule does not support extended registration write data source Aug 15, 2019
@sczyh30 sczyh30 added area/integrations Issues or PRs related to integrations with open-source components kind/enhancement Category issues or prs related to enhancement. area/gateway-flow-control Issues or PRs related to API gateway flow control labels Aug 15, 2019
@sczyh30 sczyh30 changed the title Gateway mode traffic limiting rule GatewayFlowRule does not support extended registration write data source Support registering writable data-source for GatewayFlowRule and customized ApiDefinition Aug 15, 2019
@sczyh30 sczyh30 added the good first issue Good for newcomers label Aug 15, 2019
@sczyh30
Copy link
Member

sczyh30 commented Aug 15, 2019

Maybe we could just support registering the WritableDataSource in their respective command handler (e.g. UpdateGatewayApiDefinitionGroupCommandHandler and UpdateGatewayRuleCommandHandler).

An example is ModifyParamFlowRulesCommandHandler. Contributions are welcomed!

@zhaoyuguang
Copy link
Collaborator

I wanna try to finish this issue~

@mark8866
Copy link
Contributor

I had finished this issue~.

@sczyh30
Copy link
Member

sczyh30 commented Sep 20, 2019

👍 Looking forward to your PR!

@yjygalb
Copy link

yjygalb commented Dec 10, 2019

@zhangyide I have pushed gateway rules and apidefinition to zookeeper,but I can not read them from the client side using ZookeeperDataSource, can you show me hao to read them from the client side,thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/gateway-flow-control Issues or PRs related to API gateway flow control area/integrations Issues or PRs related to integrations with open-source components good first issue Good for newcomers kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
6 participants