Feature: support registering writable data-source for GatewayFlowRule and customized ApiDefinition #1057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
sczyh30
added
area/gateway-flow-control
mark8866
changed the title
|
Could you please sign the CLA here: https://cla-assistant.io/alibaba/Sentinel?pullRequest=1057 |
Codecov Report
@@ Coverage Diff @@
## master #1057 +/- ##
===========================================
- Coverage 43.1% 43.01% -0.1%
+ Complexity 1493 1492 -1
===========================================
Files 317 317
Lines 9295 9321 +26
Branches 1269 1271 +2
===========================================
+ Hits 4007 4009 +2
- Misses 4794 4818 +24
Partials 494 494
Continue to review full report at Codecov.
|
ok |
cdfive
reviewed
Sep 21, 2019
...com/alibaba/csp/sentinel/adapter/gateway/common/command/UpdateGatewayRuleCommandHandler.java
Outdated
Show resolved
Hide resolved
sczyh30
reviewed
Sep 23, 2019
...com/alibaba/csp/sentinel/adapter/gateway/common/command/UpdateGatewayRuleCommandHandler.java
Outdated
Show resolved
Hide resolved
|
Thanks for contributing! |
sczyh30
changed the title
hughpearse
pushed a commit
to hughpearse/Sentinel
that referenced
this pull request
Jun 2, 2021
…omized ApiDefinition (alibaba#1057)
CST11021
pushed a commit
to CST11021/Sentinel
that referenced
this pull request
Nov 3, 2021
…libaba#1177) * Filter out docker0 when finding a local address * sweep out bridge interface Co-authored-by: yuanyuan.xia <yuanyuan.xia@envisioncn.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Does this pull request fix one issue?
Resolves #992
Describe how you did it
Describe how to verify it
Special notes for reviews