Fixes #9: Use named thread factory for identification #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
sczyh30
added
the
kind/enhancement
Codecov Report
@@ Coverage Diff @@
## master #10 +/- ##
===========================================
+ Coverage 46.32% 46.4% +0.08%
- Complexity 540 542 +2
===========================================
Files 105 105
Lines 3655 3655
Branches 517 517
===========================================
+ Hits 1693 1696 +3
+ Misses 1756 1754 -2
+ Partials 206 205 -1
Continue to review full report at Codecov.
|
CarpenterLee
requested changes
Jul 30, 2018
| @@ -54,7 +55,8 @@ | |||
| public class FlowRuleManager { | |||
|
|
|||
| private static final Map<String, List<FlowRule>> flowRules = new ConcurrentHashMap<String, List<FlowRule>>(); | |||
| private final static ScheduledExecutorService scheduler = Executors.newScheduledThreadPool(1); | |||
| private final static ScheduledExecutorService scheduler = Executors.newScheduledThreadPool(1, | |||
| new NamedThreadFactory("sentinel-flow-metrics-record-task", true)); | |||
There was a problem hiding this comment.
should change "sentinel-flow-metrics-record-task" to "sentinel-metrics-record-task"
sczyh30
added a commit
that referenced
this pull request
Aug 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Eric Zhao sczyh16@gmail.com
Describe what this PR does / why we need it
Use named thread factory with all thread pools for identification.
Does this pull request fix one issue?
Fixes #9