Support URL exclusion using UrlCleaner in Spring WebFlux adapter #1049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1049 +/- ##
============================================
- Coverage 42.64% 42.61% -0.03%
Complexity 1472 1472
============================================
Files 317 317
Lines 9286 9290 +4
Branches 1267 1269 +2
============================================
- Hits 3960 3959 -1
- Misses 4833 4836 +3
- Partials 493 495 +2
Continue to review full report at Codecov.
|
sczyh30
reviewed
Sep 18, 2019
| @@ -55,7 +55,7 @@ For REST APIs, you have to clean the URL resource (e.g. `/foo/1` and `/foo/2` -> | |||
| the amount of context and resources will exceed the threshold. | |||
|
|
|||
| If you need to exclude some URLs (that should not be recorded as Sentinel resources), you could also | |||
| leverage the `UrlCleaner` interface. You may unify the unwanted URLs to the empty string `""`, | |||
| leverage the `UrlCleaner` interface. You may unify the unwanted URLs to the empty string `""` or null, | |||
There was a problem hiding this comment.
This PR is for Spring WebFlux adapter only, so it might be better to make this change in other PRs.
There was a problem hiding this comment.
Ok, I will try to change this in another PR.
sczyh30
reviewed
Sep 18, 2019
...ter/src/main/java/com/alibaba/csp/sentinel/adapter/spring/webflux/SentinelWebFluxFilter.java
Outdated
Show resolved
Hide resolved
|
Thanks for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Does this pull request fix one issue?
Resolves #1020
Describe how you did it
Describe how to verify it
Special notes for reviews