Improve the SPI ClassLoader mechanism to handle more complex scenarios #1088
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Improve the SPI ClassLoader mechanism to handle more complex scenarios.
Does this pull request fix one issue?
Resolves #1087
Describe how you did it
csp.sentinel.spi.classloader
to indicate which ClassLoader should be used when loading SPI implementations. By default Sentinel will use the default ClassLoader (i.e.clazz.getClassLoader()
). Only if the property is set tocontext
, Sentinel will try to load SPI implementations with the thread context ClassLoader.ServiceLoaderUtil
class as the universalServiceLoader
wrapper, and improve theSpiLoader
.ServiceLoaderUtil
instead.Describe how to verify it
Run all test cases and demo.
Special notes for reviews
This PR contains internal breaking change. Please verify it in scenarios with advanced ClassLoader mechanism.