Fixes #74: Support JDK-based proxy in Sentinel annotation support #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The method from the signature will return the method of interface, so we need to resolve declared method in target class Signed-off-by: Eric Zhao <sczyh16@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #111 +/- ##
=========================================
Coverage 45.81% 45.81%
Complexity 556 556
=========================================
Files 114 114
Lines 3813 3813
Branches 531 531
=========================================
Hits 1747 1747
Misses 1855 1855
Partials 211 211Continue to review full report at Codecov.
|
sczyh30
added a commit
that referenced
this pull request
Sep 19, 2018
- The method from the signature will return the method of interface, so we need to resolve declared method in target class Signed-off-by: Eric Zhao <sczyh16@gmail.com>
Arlmls
pushed a commit
to Arlmls/Sentinel
that referenced
this pull request
Jan 8, 2019
…#111) - The method from the signature will return the method of interface, so we need to resolve declared method in target class Signed-off-by: Eric Zhao <sczyh16@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Support JDK-based proxy in Sentinel annotation support. In Sentinel 0.1.1, JDK-based proxy is not supported because
signature.getMethodreturns the method of interface. So in some circumstances we need to get declared method.Spring Boot 2.x uses cglib-based proxy by default, but Spring Boot 1.x uses JDK-based proxy by default, causing some problems.
Does this pull request fix one issue?
Fixes #74
Describe how you did it
See
resolveMethod.