Better compatibility of dashboard to sentinel-transport-simple-http #1260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t-simple-http(on Content-Type)
jasonjoo2010
added
kind/bug
Codecov Report
@@ Coverage Diff @@
## master #1260 +/- ##
===========================================
- Coverage 43.31% 43.3% -0.02%
Complexity 1581 1581
===========================================
Files 338 338
Lines 9905 9905
Branches 1337 1337
===========================================
- Hits 4290 4289 -1
- Misses 5089 5090 +1
Partials 526 526
Continue to review full report at Codecov.
|
sczyh30
reviewed
Jan 19, 2020
...nel-dashboard/src/main/java/com/alibaba/csp/sentinel/dashboard/client/SentinelApiClient.java
Show resolved
Hide resolved
sczyh30
reviewed
Jan 19, 2020
...dashboard/src/test/java/com/alibaba/csp/sentinel/dashboard/client/SentinelApiClientTest.java
Show resolved
Hide resolved
|
Thanks! |
hughpearse
pushed a commit
to hughpearse/Sentinel
that referenced
this pull request
Jun 2, 2021
…ST request (alibaba#1260) * Better compatibility of the dashboard to legacy and new sentinel-transport-simple-http (on Content-Type header), related to alibaba#1207
CST11021
pushed a commit
to CST11021/Sentinel
that referenced
this pull request
Nov 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better compatibility of dashboard to sentinel-transport-simple-http(on Content-Type)
Describe what this PR does / why we need it
Use legacy strict
Content-Typeto legacysentinel-transport.Does this pull request fix one issue?
Related to #1236
Special notes for reviews
Special dealing only for those transport module <
1.7.1