Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix [ #1428] Support ZuulBlockFallbackProvider to return information custom #1508

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

liuweiGit
Copy link

@liuweiGit liuweiGit commented May 27, 2020

Describe what this PR does / why we need it

Does this pull request fix one issue?

fix 1428

Describe how you did it

Response.ok().put("");

Describe how to verify it

Special notes for reviews

sczyh30 and others added 18 commits December 25, 2019 10:20
* Also polish related complete callbacks

Signed-off-by: Eric Zhao <sczyh16@gmail.com>
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented May 27, 2020

Codecov Report

Attention: Patch coverage is 64.40678% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 44.05%. Comparing base (ff0e53f) to head (73a7e3b).
Report is 230 commits behind head on master.

❗ Current head 73a7e3b differs from pull request most recent head be0322d. Consider uploading reports for the commit be0322d to get more accurate results

Files Patch % Lines
.../adapter/gateway/zuul2/fallback/BlockResponse.java 52.38% 10 Missing ⚠️
...l/adapter/gateway/zuul/fallback/BlockResponse.java 66.66% 7 Missing ⚠️
...er/gateway/zuul/filters/SentinelZuulPreFilter.java 0.00% 3 Missing ⚠️
...ateway/zuul/fallback/ZuulBlockFallbackManager.java 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1508      +/-   ##
============================================
- Coverage     44.58%   44.05%   -0.54%     
+ Complexity     1804     1733      -71     
============================================
  Files           382      376       -6     
  Lines         10912    10690     -222     
  Branches       1467     1423      -44     
============================================
- Hits           4865     4709     -156     
+ Misses         5451     5412      -39     
+ Partials        596      569      -27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sczyh30 sczyh30 added the kind/enhancement Category issues or prs related to enhancement. label Jun 5, 2020
@CLAassistant
Copy link

CLAassistant commented Jun 12, 2020

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 6 committers have signed the CLA.

✅ sczyh30
✅ liuweiGit
❌ 刘伟
❌ linlinisme
❌ zhenxianyimeng
❌ joooohnli


刘伟 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants