Support degrade by exception count #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sczyh30
changed the title
Arlmls
pushed a commit
to Arlmls/Sentinel
that referenced
this pull request
Jan 8, 2019
* Add a new DegradeRule type, degrade by exception count in the last 60 seconds * Add demo about degrading by exception count
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
DegradeRule only have two type now, one is by RT, the other is by exception ratio. Degrade by exception count is not supported, which is necessary in the real case.
Does this pull request fix one issue?
Fixes #173
Describe how you did it
Add a new DegradeRule type, degrade by exception count in the last minute. Degradation will be triggered if exception count in the last 60 seconds greats than or equals to the threshold.
Describe how to verify it
See test cases.
Special notes for reviews
None