Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix HttpServerHandler body reading problem #185

Merged
merged 1 commit into from
Oct 16, 2018

Conversation

jasonjoo2010
Copy link
Collaborator

@jasonjoo2010 jasonjoo2010 commented Oct 16, 2018

Describe what this PR does / why we need it

fix HttpServerHandler body reading problem.

When post data to netty-http an exception UnsupportedOperationException will occur.

Does this pull request fix one issue?

Fixes #184

Describe how you did it

Do a manual copying from unpooled direct buffer.

Describe how to verify it

curl -d "something" "http://api_provided_by_command_center"

@codecov-io
Copy link

Codecov Report

Merging #185 into master will decrease coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #185      +/-   ##
============================================
- Coverage     51.29%   51.14%   -0.15%     
+ Complexity      829      826       -3     
============================================
  Files           140      140              
  Lines          4753     4753              
  Branches        677      677              
============================================
- Hits           2438     2431       -7     
- Misses         2020     2031      +11     
+ Partials        295      291       -4
Impacted Files Coverage Δ Complexity Δ
...a/csp/sentinel/slots/statistic/base/Striped64.java 50% <0%> (-5.21%) 7% <0%> (-1%)
...a/csp/sentinel/slots/statistic/base/LeapArray.java 68.96% <0%> (-3.45%) 17% <0%> (-1%)
...a/csp/sentinel/slots/statistic/base/LongAdder.java 31.91% <0%> (ø) 8% <0%> (-1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0916a9b...b27f894. Read the comment docs.

@sczyh30 sczyh30 added the to-review To review label Oct 16, 2018
Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 merged commit d861a36 into alibaba:master Oct 16, 2018
@sczyh30 sczyh30 removed the to-review To review label Oct 16, 2018
@sczyh30
Copy link
Member

sczyh30 commented Oct 16, 2018

Thanks for contributing!

Arlmls pushed a commit to Arlmls/Sentinel that referenced this pull request Jan 8, 2019
…etty-http (alibaba#185)

- Do a manual copying from unpooled direct buffer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception when post data to transport api
3 participants