Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix flaky test in TracerTest.java #1859

Merged
merged 4 commits into from Nov 27, 2020
Merged

fix flaky test in TracerTest.java #1859

merged 4 commits into from Nov 27, 2020

Conversation

zcai2
Copy link
Contributor

@zcai2 zcai2 commented Nov 16, 2020

Fixed flaky test that caused by setExceptionPredicate.

For setExceptionsToTrace and setExceptionsToIgnore, if we called setExceptionPredicate first, it will assigned value to Tracer.exceptionPredicate.

To avoid this case, we would better to reset exceptionPredicate to null first

The flaky tests are found by running https://github.com/idflakies/iDFlakies

@CLAassistant
Copy link

CLAassistant commented Nov 16, 2020

CLA assistant check
All committers have signed the CLA.

@sczyh30
Copy link
Member

sczyh30 commented Nov 16, 2020

Hi, thanks for contributing. Could you please sign the CLA here? And please make sure the email of your commits match your GitHub email. You may refer to the instruction here, or rebase your commits with the correct email.


感谢贡献,请将 commit 对应的 email 调整成与 GitHub 的 email 相匹配并 确认一下 CLA

@sczyh30 sczyh30 added the area/test Issue or PR related to test cases label Nov 16, 2020
@zcai2
Copy link
Contributor Author

zcai2 commented Nov 21, 2020

Hi,
I have signed the CLA and update my email as well.

@zcai2 zcai2 changed the title flaky test on TracerTest.java fix flaky test in TracerTest.java Nov 21, 2020
@sczyh30
Copy link
Member

sczyh30 commented Nov 23, 2020

It could be better if you could clear the exceptionPredicate via @Before and @After period.

@sczyh30 sczyh30 merged commit 6f7d4d0 into alibaba:master Nov 27, 2020
@sczyh30
Copy link
Member

sczyh30 commented Nov 27, 2020

Thanks for contributing!

hughpearse pushed a commit to hughpearse/Sentinel that referenced this pull request Jun 2, 2021
CST11021 pushed a commit to CST11021/Sentinel that referenced this pull request Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test Issue or PR related to test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants