Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for authority rule configuration in Sentinel Dashboard #189

Merged
merged 1 commit into from
Oct 23, 2018

Conversation

sczyh30
Copy link
Member

@sczyh30 sczyh30 commented Oct 18, 2018

Describe what this PR does / why we need it

Add support for authority rule configuration in Sentinel Dashboard.

Does this pull request fix one issue?

Resolves #178

Describe how you did it

  • Update dashboard API client to support authority rule commands
  • Add REST API and frontend page for authority rules

Describe how to verify it

Run the dashboard to verify the functions.

Special notes for reviews

None

Signed-off-by: Eric Zhao <sczyh16@gmail.com>
@sczyh30 sczyh30 added the to-review To review label Oct 18, 2018
@codecov-io
Copy link

Codecov Report

Merging #189 into master will increase coverage by 0.6%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #189     +/-   ##
===========================================
+ Coverage      50.4%   51.01%   +0.6%     
- Complexity      821      826      +5     
===========================================
  Files           140      140             
  Lines          4763     4763             
  Branches        678      678             
===========================================
+ Hits           2401     2430     +29     
+ Misses         2074     2039     -35     
- Partials        288      294      +6
Impacted Files Coverage Δ Complexity Δ
...a/com/alibaba/csp/sentinel/node/StatisticNode.java 65.07% <0%> (-1.59%) 17% <0%> (-1%)
...a/csp/sentinel/slots/statistic/base/LongAdder.java 31.91% <0%> (+14.89%) 8% <0%> (+4%) ⬆️
...a/csp/sentinel/slots/statistic/base/Striped64.java 50% <0%> (+23.95%) 7% <0%> (+2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aaf88b8...06c323d. Read the comment docs.

Copy link
Contributor

@CarpenterLee CarpenterLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@CarpenterLee CarpenterLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 merged commit 0855809 into master Oct 23, 2018
@sczyh30 sczyh30 deleted the dashboard/authority-rule branch October 23, 2018 01:20
@sczyh30 sczyh30 removed the to-review To review label Oct 23, 2018
Arlmls pushed a commit to Arlmls/Sentinel that referenced this pull request Jan 8, 2019
…libaba#189)

- Update dashboard API client to support authority rule commands
- Add REST API and frontend page for authority rules

Signed-off-by: Eric Zhao <sczyh16@gmail.com>
CST11021 pushed a commit to CST11021/Sentinel that referenced this pull request Nov 3, 2021
[ROCKETMQ-270] Move flush position forward to first MappedFile whose start offset is non-zero
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support configuring authority rules via Sentinel Dashboard
3 participants