Fixes #198: Enhance rule checking in rule managers and Sentinel Dashboard #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Enhance error information when reporting invalid fields in rule dialog Signed-off-by: Eric Zhao <sczyh16@gmail.com>
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #202 +/- ##
============================================
+ Coverage 50.75% 51.58% +0.83%
- Complexity 827 853 +26
============================================
Files 140 140
Lines 4798 4819 +21
Branches 683 692 +9
============================================
+ Hits 2435 2486 +51
+ Misses 2073 2024 -49
- Partials 290 309 +19
Continue to review full report at Codecov.
|
Arlmls
pushed a commit
to Arlmls/Sentinel
that referenced
this pull request
Jan 8, 2019
…l Dashboard (alibaba#202) - Enhance rule checking in rule managers and Sentinel Dashboard frontend - Enhance error information when reporting invalid fields in rule dialog Signed-off-by: Eric Zhao <sczyh16@gmail.com>
CST11021
pushed a commit
to CST11021/Sentinel
that referenced
this pull request
Nov 3, 2021
* Add an interface DecryptionStrategy for SslHelper * Centralize the TLS related configurations * Use tls test mode by default * Add SSL related tests * Add tls related tests * Add tls config related unit tests * Pass TLS unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Enhance rule checking in rule managers and Sentinel Dashboard frontend.
Does this pull request fix one issue?
Fixes #198
Also related to #153
Describe how you did it
Describe how to verify it
Run the dashboard and input invalid fields in rule dialog.
Special notes for reviews
None.