Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client ip property in transport common module #261

Merged
merged 2 commits into from
Dec 3, 2018
Merged

Add client ip property in transport common module #261

merged 2 commits into from
Dec 3, 2018

Conversation

nick-tan
Copy link
Contributor

Describe what this PR does / why we need it

增加客户度ip可配置。让docker环境部署时可以指定宿主机IP。
若配置了客户端ip则用配置的ip,否则用获取的本地host的ip

Does this pull request fix one issue?

Fixes #246

@CLAassistant
Copy link

CLAassistant commented Nov 24, 2018

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

codecov-io commented Nov 24, 2018

Codecov Report

Merging #261 into master will decrease coverage by 3.61%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #261      +/-   ##
============================================
- Coverage     49.83%   46.22%   -3.62%     
- Complexity      915      924       +9     
============================================
  Files           158      181      +23     
  Lines          5259     5746     +487     
  Branches        757      830      +73     
============================================
+ Hits           2621     2656      +35     
- Misses         2306     2753     +447     
- Partials        332      337       +5
Impacted Files Coverage Δ Complexity Δ
...csp/sentinel/transport/config/TransportConfig.java 33.33% <100%> (ø) 3 <2> (?)
...tinel/command/handler/FetchTreeCommandHandler.java 0% <0%> (ø) 0% <0%> (?)
...l/command/handler/FetchJsonTreeCommandHandler.java 0% <0%> (ø) 0% <0%> (?)
...ntinel/transport/init/HeartbeatSenderInitFunc.java 0% <0%> (ø) 0% <0%> (?)
...nd/handler/FetchClusterNodeByIdCommandHandler.java 0% <0%> (ø) 0% <0%> (?)
...d/handler/FetchClusterNodeHumanCommandHandler.java 0% <0%> (ø) 0% <0%> (?)
...nel/transport/util/WritableDataSourceRegistry.java 0% <0%> (ø) 0% <0%> (?)
...ntinel/command/handler/OnOffSetCommandHandler.java 0% <0%> (ø) 0% <0%> (?)
...entinel/command/handler/VersionCommandHandler.java 0% <0%> (ø) 0% <0%> (?)
...mmand/handler/FetchSystemStatusCommandHandler.java 0% <0%> (ø) 0% <0%> (?)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c80bb5a...c334895. Read the comment docs.

@sczyh30 sczyh30 added the to-review To review label Nov 26, 2018
@sczyh30
Copy link
Member

sczyh30 commented Nov 29, 2018

And please add test cases for new added getClientIp method.

Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 merged commit eb29cc9 into alibaba:master Dec 3, 2018
@sczyh30
Copy link
Member

sczyh30 commented Dec 3, 2018

Thanks for contributing!

@sczyh30 sczyh30 removed the to-review To review label Dec 3, 2018
@sczyh30 sczyh30 changed the title 增加client ip配置变量 Add client ip property in transport common module Dec 3, 2018
@sczyh30 sczyh30 added this to the 1.4.0 milestone Dec 3, 2018
Arlmls pushed a commit to Arlmls/Sentinel that referenced this pull request Jan 8, 2019
@pstree
Copy link

pstree commented Apr 20, 2020

spring.cloud.inetutils.preferred-networks=172. 没有这样的参数支持多网卡吗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docker 导致无法正常监控
5 participants