Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use unified entrance context name in Spring WebFlux adapter #2610

Merged
merged 1 commit into from Mar 21, 2022

Conversation

icodening
Copy link
Contributor

Describe what this PR does / why we need it

fix the issue of wrong context name on "spring webflux"

Does this pull request fix one issue?

Fixes #2592

Describe how you did it

modify the context name of "ContextConfig" in SentinelWebFluxFilter

Describe how to verify it

use webflux adapter to verify

<dependency>
    <groupId>com.alibaba.csp</groupId>
    <artifactId>sentinel-spring-webflux-adapter</artifactId>
</dependency>

Special notes for reviews

@sczyh30 sczyh30 changed the title fix sentinel spring web flux context name Use unified entrance context name in Spring WebFlux adapter Mar 21, 2022
@sczyh30 sczyh30 merged commit 0bb7532 into alibaba:master Mar 21, 2022
@sczyh30
Copy link
Member

sczyh30 commented Mar 21, 2022

@sczyh30 sczyh30 added the kind/enhancement Category issues or prs related to enhancement. label Mar 21, 2022
@icodening icodening deleted the bugfix_webflux_contextname branch March 21, 2022 15:04
@icodening
Copy link
Contributor Author

Thanks for contributing! It might be better if this can be configured like webContextUnify attribute in https://github.com/alibaba/Sentinel/blob/master/sentinel-adapter/sentinel-spring-webmvc-adapter/src/main/java/com/alibaba/csp/sentinel/adapter/spring/webmvc/config/SentinelWebMvcConfig.java

ok, this looks better

@sczyh30 sczyh30 added this to the 1.8.4 milestone Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
2 participants