Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replacing deprecated config key for Dashboard #2713

Merged
merged 1 commit into from
May 10, 2022

Conversation

icodening
Copy link
Contributor

Describe what this PR does / why we need it

replacing deprecated config key

Does this pull request fix one issue?

Fixes #2712

Describe how you did it

replace key

Describe how to verify it

logging.file The specified directory did not generate logs
logging.file.name The specified directory generate logs

refer spring.http.* https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-2.3-Release-Notes#deprecations-in-spring-boot-23
refer logging.*https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-2.2-Release-Notes#deprecations-in-spring-boot-22

@sczyh30 sczyh30 added the area/dashboard Issues or PRs about Sentinel Dashboard label May 10, 2022
Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 merged commit d358b1d into alibaba:master May 10, 2022
@sczyh30
Copy link
Member

sczyh30 commented May 10, 2022

Thanks for contributing!

@icodening icodening deleted the issue2712 branch May 16, 2022 13:45
@sczyh30 sczyh30 added this to the 1.8.5 milestone Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dashboard Issues or PRs about Sentinel Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replacing deprecated config key for Dashboard
2 participants