Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic support for cluster flow control in Sentinel dashboard #302

Merged
merged 2 commits into from
Dec 14, 2018

Conversation

sczyh30
Copy link
Member

@sczyh30 sczyh30 commented Dec 14, 2018

Describe what this PR does / why we need it

Add basic support for cluster flow control in Sentinel dashboard

Does this pull request fix one issue?

Related to #200

Describe how you did it

  • Update SentinelApiClient to support new-added command APIs
  • Add controller for cluster config
  • Add flow controller v2 for global rule pulling / pushing
  • Extract dynamic rule provider and publisher interface for customized extensions
  • Add basic cluster config service
  • Add basic Nacos integration (in test as an example)
  • Add frontend service and pages for Sentinel cluster flow control

Describe how to verify it

Run the dashboard.

Special notes for reviews

None.

- Update SentinelApiClient to support new-added command APIs
- Add controller for cluster config
- Add flow controller v2 for global rule pulling / pushing
- Extract dynamic rule provider and publisher interface for customized extensions
- Add basic cluster config service
- Add basic Nacos integration (in test as an example)

Signed-off-by: Eric Zhao <sczyh16@gmail.com>
…ashboard

Signed-off-by: Eric Zhao <sczyh16@gmail.com>
@sczyh30 sczyh30 added the to-review To review label Dec 14, 2018
@sczyh30 sczyh30 added this to the 1.4.0 milestone Dec 14, 2018
Copy link
Contributor

@CarpenterLee CarpenterLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

Codecov Report

Merging #302 into master will increase coverage by 0.49%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #302      +/-   ##
===========================================
+ Coverage     38.31%   38.8%   +0.49%     
- Complexity      932     941       +9     
===========================================
  Files           219     219              
  Lines          6921    6921              
  Branches        939     939              
===========================================
+ Hits           2652    2686      +34     
+ Misses         3937    3892      -45     
- Partials        332     343      +11
Impacted Files Coverage Δ Complexity Δ
...s/block/flow/controller/RateLimiterController.java 79.16% <0%> (-12.5%) 5% <0%> (-1%)
...a/com/alibaba/csp/sentinel/node/StatisticNode.java 67.21% <0%> (+1.63%) 22% <0%> (+1%) ⬆️
...a/csp/sentinel/slots/statistic/base/LongAdder.java 31.91% <0%> (+14.89%) 10% <0%> (+6%) ⬆️
...a/csp/sentinel/slots/statistic/base/Striped64.java 56.25% <0%> (+30.2%) 8% <0%> (+3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fba114d...bd2049b. Read the comment docs.

1 similar comment
@codecov-io
Copy link

Codecov Report

Merging #302 into master will increase coverage by 0.49%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #302      +/-   ##
===========================================
+ Coverage     38.31%   38.8%   +0.49%     
- Complexity      932     941       +9     
===========================================
  Files           219     219              
  Lines          6921    6921              
  Branches        939     939              
===========================================
+ Hits           2652    2686      +34     
+ Misses         3937    3892      -45     
- Partials        332     343      +11
Impacted Files Coverage Δ Complexity Δ
...s/block/flow/controller/RateLimiterController.java 79.16% <0%> (-12.5%) 5% <0%> (-1%)
...a/com/alibaba/csp/sentinel/node/StatisticNode.java 67.21% <0%> (+1.63%) 22% <0%> (+1%) ⬆️
...a/csp/sentinel/slots/statistic/base/LongAdder.java 31.91% <0%> (+14.89%) 10% <0%> (+6%) ⬆️
...a/csp/sentinel/slots/statistic/base/Striped64.java 56.25% <0%> (+30.2%) 8% <0%> (+3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fba114d...bd2049b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants