Support traffic routing capability. #3024
Conversation
|
|
sczyh30
added
kind/feature
sczyh30
added
to-review
sentinel-core/src/main/java/com/alibaba/csp/sentinel/traffic/LoadBalance.java
Outdated
Show resolved
Hide resolved
sentinel-core/src/main/java/com/alibaba/csp/sentinel/traffic/RouterFilter.java
Outdated
Show resolved
Hide resolved
| /** | ||
| * @author panxiaojun233 | ||
| */ | ||
| public class Instance { |
There was a problem hiding this comment.
Do we need a toString() for entities?
There was a problem hiding this comment.
Yeah, I will fix it
| public class Route { | ||
| private String name; | ||
| private List<StringMatch> services; | ||
| private List<RouteDetail> routedetail; |
There was a problem hiding this comment.
camel case: routeDetail is better?
There was a problem hiding this comment.
Yeah, I will fix it
|
|
||
| @Override | ||
| public String toString() { | ||
| return "DubboRoute{" + |
There was a problem hiding this comment.
Please re-generate toString() for this.
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package com.alibaba.csp.sentinel.traffic.rule.vritual.workload; |
There was a problem hiding this comment.
typo: vritual -> virtual
How about just com.alibaba.csp.sentinel.traffic.rule.workload?
| private StringMatch path; | ||
| private Integer argc; | ||
| private List<ArgumentMatch> args; | ||
| private List<StringMatch> argp; |
There was a problem hiding this comment.
This seems perplexing... Maybe we could improve the naming.
| * The subscriber of traffic rule. | ||
| * @author panxiaojun233 | ||
| */ | ||
| public interface TrafficRuleSubscriber { |
There was a problem hiding this comment.
Here we actually observes the event of "remote provider app change", not the rule. So maybe RemoteAppObserver or other name is better?
The same for subscribe/unsubscribe.
panxiaojun233
force-pushed
the
feature-traffic
branch
from
c82a4ba
to
ae09653
Compare
panxiaojun233
force-pushed
the
feature-traffic
branch
from
a265fad
to
19ecab4
Compare
|
Nice work. Thanks for contributing! |
Describe what this PR does / why we need it
Support traffic routing capability based on OpenSergo TrafficRouter
Does this pull request fix one issue?
Fixes #3023
Describe how you did it
Refer the design notes in #3023
Describe how to verify it
Run the test cases and demo.
A relevant Dubbo extension that integrates with the traffic router: apache/dubbo-spi-extensions#192
Special notes for reviews
IMPORTANT: we may need to discuss the module and package structure of the nouveau traffic routing code. See #3025