Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

示例中 isEmpty 导致规则不能删除 #353

Merged
merged 1 commit into from
Dec 28, 2018
Merged

示例中 isEmpty 导致规则不能删除 #353

merged 1 commit into from
Dec 28, 2018

Conversation

foreveryang321
Copy link
Contributor

Describe what this PR does / why we need it
Translated from Google:
In the example isEmpty causes the rule to not be deleted

Does this pull request fix one issue?
NONE

Describe how you did it
Describe how to verify it
Special notes for reviews

Translated from Google:
In the example isEmpty causes the rule to not be deleted
@sczyh30 sczyh30 added the to-review To review label Dec 28, 2018
@codecov-io
Copy link

Codecov Report

Merging #353 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #353      +/-   ##
============================================
- Coverage     38.25%   38.21%   -0.05%     
+ Complexity      937      936       -1     
============================================
  Files           218      218              
  Lines          6966     6966              
  Branches        948      948              
============================================
- Hits           2665     2662       -3     
- Misses         3964     3966       +2     
- Partials        337      338       +1
Impacted Files Coverage Δ Complexity Δ
...a/csp/sentinel/slots/statistic/base/LeapArray.java 64.55% <0%> (-3.8%) 23% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25289c2...7bcced0. Read the comment docs.

Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 merged commit f4d1ac9 into alibaba:master Dec 28, 2018
@sczyh30
Copy link
Member

sczyh30 commented Dec 28, 2018

Thanks for contributing!

@sczyh30 sczyh30 removed the to-review To review label Dec 28, 2018
Arlmls pushed a commit to Arlmls/Sentinel that referenced this pull request Jan 8, 2019
…libaba#353)

- the wrong `isEmpty` check causes the rule cannot be deleted
CST11021 pushed a commit to CST11021/Sentinel that referenced this pull request Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants