Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug of calculating param size and amount in ParamFlowRequestDataWriter of Sentinel cluster #495

Merged
merged 2 commits into from
Feb 20, 2019

Conversation

sczyh30
Copy link
Member

@sczyh30 sczyh30 commented Feb 19, 2019

Describe what this PR does / why we need it

Fix bug of calculating param size and amount in ParamFlowRequestDataWriter of Sentinel cluster.

Does this pull request fix one issue?

Pending

Describe how you did it

Null object or non-primitive objects will not be calculated and transferred to the token server. And add warn log when there are non-primitive objects.

Describe how to verify it

Run the test cases.

Special notes for reviews

NONE.

…m-flow entity decoder

- Add basic test cases

Signed-off-by: Eric Zhao <sczyh16@gmail.com>
@sczyh30 sczyh30 added the to-review To review label Feb 19, 2019
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
Copy link
Contributor

@CarpenterLee CarpenterLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

codecov-io commented Feb 20, 2019

Codecov Report

Merging #495 into master will decrease coverage by 2.55%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #495      +/-   ##
============================================
- Coverage     40.72%   38.17%   -2.56%     
- Complexity     1095     1111      +16     
============================================
  Files           236      259      +23     
  Lines          7570     8155     +585     
  Branches       1050     1109      +59     
============================================
+ Hits           3083     3113      +30     
- Misses         4090     4638     +548     
- Partials        397      404       +7
Impacted Files Coverage Δ Complexity Δ
...sentinel/cluster/flow/ClusterParamFlowChecker.java 0% <0%> (ø) 0 <0> (ø) ⬇️
.../client/codec/data/ParamFlowRequestDataWriter.java 37.17% <76.92%> (ø) 14 <10> (?)
...a/csp/sentinel/slots/statistic/base/LeapArray.java 69.62% <0%> (-2.54%) 25% <0%> (-1%)
.../sentinel/cluster/client/NettyTransportClient.java 0% <0%> (ø) 0% <0%> (?)
...mmand/handler/FetchClusterClientConfigHandler.java 0% <0%> (ø) 0% <0%> (?)
...ter/client/codec/data/PingResponseDataDecoder.java 0% <0%> (ø) 0% <0%> (?)
...ient/codec/registry/RequestDataWriterRegistry.java 0% <0%> (ø) 0% <0%> (?)
...luster/client/codec/ClientEntityCodecProvider.java 0% <0%> (ø) 0% <0%> (?)
...uster/client/handler/TokenClientPromiseHolder.java 0% <0%> (ø) 0% <0%> (?)
...nel/cluster/client/handler/TokenClientHandler.java 0% <0%> (ø) 0% <0%> (?)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee4a0d4...35c6a39. Read the comment docs.

@sczyh30 sczyh30 added this to the 1.4.2 milestone Feb 20, 2019
@sczyh30 sczyh30 changed the title Fix bug of handling non-primitive types in ParamFlowRequestDataWriter of Sentinel cluster Fix bug of calculating param size and amount in ParamFlowRequestDataWriter of Sentinel cluster Feb 20, 2019
@sczyh30 sczyh30 merged commit f7c08df into master Feb 20, 2019
@sczyh30 sczyh30 removed the to-review To review label Feb 20, 2019
@sczyh30 sczyh30 deleted the fix/cluster-param-decoder branch February 20, 2019 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants