Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dynamic data-source integration with Nacos #8

Merged
merged 2 commits into from
Jul 30, 2018

Conversation

sczyh30
Copy link
Member

@sczyh30 sczyh30 commented Jul 30, 2018

Describe what this PR does / why we need it

Add dynamic rule configuration integration (DataSource) with Nacos.

Does this pull request fix one issue?

Closes #7

Describe how you did it

  1. User should provide serverAddress, groupId and dataId of Nacos, as well as a config parser that can parse string to target type.
  2. The Nacos datasource will initiate a ConfigService and bind with a listener, where Sentinel can get real-time configuration update.
  3. The Nacos datasource will pull the initial config when initializing. Then listen to remote changes.

See NacosDataSource for details.

Signed-off-by: Eric Zhao <sczyh16@gmail.com>
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
@sczyh30 sczyh30 added the kind/enhancement Category issues or prs related to enhancement. label Jul 30, 2018
@CLAassistant
Copy link

CLAassistant commented Jul 30, 2018

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

Codecov Report

Merging #8 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master       #8      +/-   ##
============================================
+ Coverage     46.48%   46.51%   +0.02%     
  Complexity      543      543              
============================================
  Files           105      105              
  Lines          3655     3655              
  Branches        517      517              
============================================
+ Hits           1699     1700       +1     
  Misses         1751     1751              
+ Partials        205      204       -1
Impacted Files Coverage Δ Complexity Δ
...csp/sentinel/property/DynamicSentinelProperty.java 59.25% <100%> (+3.7%) 6 <0> (ø) ⬇️
...el/slots/block/flow/controller/PaceController.java 78.26% <0%> (-13.05%) 4% <0%> (-1%)
...ntinel/slots/statistic/metric/WindowLeapArray.java 80.64% <0%> (+9.67%) 8% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d5b19e...f532e04. Read the comment docs.

Copy link
Contributor

@CarpenterLee CarpenterLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CarpenterLee CarpenterLee merged commit cd9ae9a into master Jul 30, 2018
@CarpenterLee CarpenterLee deleted the feature/nacos-datasource branch July 30, 2018 09:40
linlinisme added a commit that referenced this pull request Mar 5, 2020
CST11021 pushed a commit to CST11021/Sentinel that referenced this pull request Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Dynamic configuration integration with Nacos
4 participants