Add support for request item pattern matching in API gateway flow control #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update GatewayParamParser to support matching the request item. - Update the internal logic of converting gateway rules to parameter flow rules. - Add a GatewayRegexCache to cache the compiled regex for performance - Update test cases and demo Signed-off-by: Eric Zhao <sczyh16@gmail.com>
sczyh30
added
to-review
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #842 +/- ##
============================================
+ Coverage 41.73% 41.95% +0.21%
- Complexity 1383 1400 +17
============================================
Files 305 306 +1
Lines 8807 8843 +36
Branches 1188 1196 +8
============================================
+ Hits 3676 3710 +34
Misses 4677 4677
- Partials 454 456 +2
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #842 +/- ##
============================================
+ Coverage 41.73% 41.95% +0.21%
- Complexity 1383 1400 +17
============================================
Files 305 306 +1
Lines 8807 8843 +36
Branches 1188 1196 +8
============================================
+ Hits 3676 3710 +34
Misses 4677 4677
- Partials 454 456 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Eric Zhao sczyh16@gmail.com
Describe what this PR does / why we need it
Support pattern matching for request items in API gateway flow control.
Does this pull request fix one issue?
Resolves #839
Describe how you did it
GatewayParamParserto support matching the request item.SentinelGatewayConstants.GATEWAY_NOT_MATCH_PARAM)SentinelGatewayConstants.GATEWAY_NOT_MATCH_PARAM) will be configured as an exception item with a large threshold (indicating always pass).GatewayRegexCacheto cache the compiled regex for performance.Describe how to verify it
Run the test cases and demo.
Special notes for reviews
NONE