Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the bug of getting wrong cluster flow QPS in ClusterFlowChecker #972

Merged
merged 3 commits into from
Aug 12, 2019

Conversation

ycx627954927
Copy link
Contributor

@ycx627954927 ycx627954927 commented Aug 6, 2019

Describe what this PR does / why we need it

Fix the bug when getting current cluster flow QPS in ClusterFlowChecker.

The QPS should be calculated with PASS rather than PASS_REQUEST. The PASS_REQUEST will ignore the acquireCount.

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

@CLAassistant
Copy link

CLAassistant commented Aug 6, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ changxing.yu
❌ ycx627954927


changxing.yu seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov-io
Copy link

Codecov Report

Merging #972 into master will increase coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #972      +/-   ##
============================================
+ Coverage     42.61%   42.63%   +0.02%     
  Complexity     1443     1443              
============================================
  Files           310      310              
  Lines          8985     8985              
  Branches       1222     1222              
============================================
+ Hits           3829     3831       +2     
+ Misses         4691     4689       -2     
  Partials        465      465
Impacted Files Coverage Δ Complexity Δ
.../csp/sentinel/cluster/flow/ClusterFlowChecker.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...tinel/slots/block/flow/param/ParamFlowChecker.java 55.4% <0%> (-0.68%) 29% <0%> (-1%)
...a/csp/sentinel/slots/statistic/base/LeapArray.java 70.29% <0%> (+2.97%) 34% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebcf890...7a06427. Read the comment docs.

@sczyh30
Copy link
Member

sczyh30 commented Aug 6, 2019

Hi, thanks for contributing. Could you please sign the CLA here? And please make sure the email of your commits match your GitHub email.


感谢贡献,请将 commit 对应的 email 调整成与 GitHub 的 email 相匹配并 确认一下 CLA

@sczyh30
Copy link
Member

sczyh30 commented Aug 11, 2019

Friendly ping :)

@sczyh30 sczyh30 added area/cluster-flow Issues or PRs related to cluster flow control kind/bug Category issues or prs related to bug. labels Aug 12, 2019
@sczyh30 sczyh30 changed the title fix get current cluster flow qps bug Fix the bug of getting wrong cluster flow QPS in ClusterFlowChecker Aug 12, 2019
Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 merged commit 17365f3 into alibaba:master Aug 12, 2019
@sczyh30 sczyh30 added this to the 1.7.0 milestone Aug 12, 2019
CST11021 pushed a commit to CST11021/Sentinel that referenced this pull request Nov 3, 2021
[RIP-9] format readme, delete useless spaces symbol
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cluster-flow Issues or PRs related to cluster flow control kind/bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants