Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nested_group 这个选项完全不 work #107

Closed
xuchen81 opened this issue Sep 1, 2018 · 3 comments
Closed

nested_group 这个选项完全不 work #107

xuchen81 opened this issue Sep 1, 2018 · 3 comments

Comments

@xuchen81
Copy link

xuchen81 commented Sep 1, 2018

举个例子吧 https://github.com/alibaba/ansible-provider/blob/master/contrib/inventory/alicloud.py#L396

self.push_group(self.inventory, key, hostname)
if self.nested_groups:
  self.push_group(self.inventory, 'tags', "tag_" + k)
  if v:
    self.push_group(self.inventory, "tag_" + k, key)

第一个 push_group, 不应该是 push_group,而应该是 push,不然的话,及时nested_group 被set成False,也会依然是 被当成True 一样的对待。

这只是一个例子而已,整个file,基本所有的地方 都有同样的问题。这个文件 我觉得 问题非常大, 需要仔细test,忽略了很多 ec2 inventory 文件对细节的处理。 @xiaozhu36 谢谢。

@xuchen81
Copy link
Author

Ping.

@xuchen81
Copy link
Author

xuchen81 commented Oct 4, 2018

@xiaozhu36???

@xiaozhu36
Copy link
Collaborator

Fixed and please check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants