删除无效代码、补齐缺失的@OverRide注解，采用内置list.sort函数无需引入工具类

Signed-off-by: hecy7 <hecy7@asiainfo.com>
alibaba · Dec 11, 2023 · acb41fc · acb41fc
1 parent 6a3bc66
commit acb41fc
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 5 deletions.
diff --git a/boot/src/main/java/com/taobao/arthas/boot/ProcessUtils.java b/boot/src/main/java/com/taobao/arthas/boot/ProcessUtils.java
@@ -375,7 +375,7 @@ private static File findJava(String javaHome) {
 
         // find the shortest path, jre path longer than jdk path
         if (javaList.size() > 1) {
-            Collections.sort(javaList, new Comparator<File>() {
+            javaList.sort(new Comparator<File>() {
                 @Override
                 public int compare(File file1, File file2) {
                     try {

diff --git a/core/src/main/java/com/taobao/arthas/core/shell/cli/CompletionUtils.java b/core/src/main/java/com/taobao/arthas/core/shell/cli/CompletionUtils.java
@@ -209,10 +209,8 @@ public static boolean completeMethodName(Completion completion) {
         // retrieve the class name
         String className;
         if (StringUtils.isBlank(lastToken)) {
-            // tokens = { " ", "CLASS_NAME", " "}
             className = tokens.get(tokens.size() - 2).value();
         } else {
-            // tokens = { " ", "CLASS_NAME", " ", "PARTIAL_METHOD_NAME"}
             className = tokens.get(tokens.size() - 3).value();
         }
 

diff --git a/core/src/main/java/com/taobao/arthas/core/shell/cli/impl/CliTokenImpl.java b/core/src/main/java/com/taobao/arthas/core/shell/cli/impl/CliTokenImpl.java
@@ -36,10 +36,12 @@ public boolean isBlank() {
         return !text;
     }
 
+    @Override
     public String raw() {
         return raw;
     }
 
+    @Override
     public String value() {
         return value;
     }

diff --git a/core/src/main/java/com/taobao/arthas/core/shell/session/impl/SessionManagerImpl.java b/core/src/main/java/com/taobao/arthas/core/shell/session/impl/SessionManagerImpl.java
@@ -55,8 +55,6 @@ public Session createSession() {
         session.put(Session.COMMAND_MANAGER, commandManager);
         session.put(Session.INSTRUMENTATION, instrumentation);
         session.put(Session.PID, pid);
-        //session.put(Session.SERVER, server);
-        //session.put(Session.TTY, term);
         String sessionId = UUID.randomUUID().toString();
         session.put(Session.ID, sessionId);