Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove java 6/7 compatibility code #2686

Merged
merged 5 commits into from
Oct 25, 2023
Merged

Remove java 6/7 compatibility code #2686

merged 5 commits into from
Oct 25, 2023

Conversation

yanyir
Copy link
Contributor

@yanyir yanyir commented Sep 25, 2023 •
edited
Loading

#2530
Revert code changes made for compatibility with older JDK versions:

  • Remove ThreadLocalRandom.java
  • Revert code changes in Decompiler and StringUtils related to line separator "\\R" handling

@yanyir yanyir marked this pull request as ready for review October 16, 2023 08:52
RaymondLam1
RaymondLam1 requested changes Oct 24, 2023
View reviewed changes
Copy link
Collaborator

@RaymondLam1 RaymondLam1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ThreadLocalRandom是之前为了兼容java 6的代码删除可以理解，但是StirngUtils.toLines(src)这段代码的更改是为了什么呢？

@yanyir
Copy link
Contributor Author

yanyir commented Oct 24, 2023

ThreadLocalRandom是之前为了兼容java 6的代码删除可以理解，但是StirngUtils.toLines(src)这段代码的更改是为了什么呢？

这是因为之前有一个提交：1c432db
我不知道除了 \R 作为行结束符的匹配模式是 Java 8 才开始支持之外，是否还有其他那样修改的理由，所以我就把它改回来了。

@hengyunabc hengyunabc added this to the 4.0.0 milestone Oct 25, 2023
@hengyunabc hengyunabc merged commit d2b358b into alibaba:master Oct 25, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaymondLam1 RaymondLam1 RaymondLam1 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yanyir @RaymondLam1 @hengyunabc