Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build failed on m1 mac clang-14 #122

Merged
merged 1 commit into from
Jun 27, 2022
Merged

Fix build failed on m1 mac clang-14 #122

merged 1 commit into from
Jun 27, 2022

Conversation

devillove084
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Jun 27, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

RainMark
RainMark approved these changes Jun 27, 2022
View reviewed changes
Copy link
Collaborator

@RainMark RainMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RainMark RainMark requested a review from ChuanqiXu9 June 27, 2022 06:35
ChuanqiXu9
ChuanqiXu9 approved these changes Jun 27, 2022
View reviewed changes
Copy link
Collaborator

@ChuanqiXu9 ChuanqiXu9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The reason may be you use new libcxx in Mac and we haven't tested that.

@ChuanqiXu9 ChuanqiXu9 merged commit 5d14230 into alibaba:main Jun 27, 2022
ChuanqiXu9 added a commit to ChuanqiXu9/async_simple that referenced this pull request Jul 22, 2022
@ChuanqiXu9 @devillove084
@PikachuHy @PikachuHyA
Testing (#4)
ab0b9a1 
* Detect the presence of [[likely]] properly (alibaba#120)

* Fix build on m1 mac clang-14 (alibaba#122)

* fix typo (alibaba#124)

* fix typo (alibaba#126)

Co-authored-by: Devillove084 <devillove084@users.noreply.github.com>
Co-authored-by: 大黄老鼠 <2931408816@qq.com>
Co-authored-by: PikachuHy <pikachuhy@linux.alibaba.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RainMark RainMark RainMark approved these changes

@ChuanqiXu9 ChuanqiXu9 ChuanqiXu9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@devillove084 @CLAassistant @RainMark @ChuanqiXu9