Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make lsp happy #364

Closed
wants to merge 1 commit into from
Closed

make lsp happy #364

wants to merge 1 commit into from

Conversation

yinghaoyu
Copy link

@yinghaoyu yinghaoyu commented Jan 25, 2024 •
edited

  1. For .clangd, see also ignore unknown compiler options clangd/clangd#662 (comment).
  2. async_simple/Future.h and async_simple/Promise.h include recursively.

@CLAassistant
Copy link

CLAassistant commented Jan 25, 2024 •
edited

CLA assistant check
All committers have signed the CLA.

ChuanqiXu9
ChuanqiXu9 approved these changes Jan 25, 2024
View reviewed changes
Copy link
Collaborator

@ChuanqiXu9 ChuanqiXu9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Let's see if the CI feels good about it.

@ChuanqiXu9
Copy link
Collaborator

It looks like it is a breaking change to require the users to include Promise.h explicitly. This may be not good. Can we teach clangd to not complain about it?

Also the formatter looks not happy too.

@yinghaoyu
Copy link
Author

std::promise as a friend class for std::future, both of them are in the same file. Emmmm, maybe it's a breaking change. Please ignore this commit.

@yinghaoyu yinghaoyu closed this Jan 25, 2024
@yinghaoyu
Copy link
Author

My clang is out of date, so the formatter is not fit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChuanqiXu9 ChuanqiXu9 ChuanqiXu9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yinghaoyu @CLAassistant @ChuanqiXu9