Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

升级rocketmq到4.8.0,并且支持环境变量优先配置 #3450

Merged
merged 1 commit into from
Apr 16, 2021

Conversation

zoemak
Copy link
Contributor

@zoemak zoemak commented Apr 12, 2021

不知出于何种考虑,deployer支持环境变量的配置,但是connector的几个插件不支持?
都是写在同一个配置(cannal.properties)的,如果一些配置支持环境变量,一些配置不支持环境变量感觉有点奇怪。

支持环境变量对容器化和集群化的配置拓展性会更强点吧。

顺便升级了一下rocketmq的版本,毕竟4.8.0也发布挺久了。

@CLAassistant
Copy link

CLAassistant commented Apr 12, 2021

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

codecov-io commented Apr 12, 2021

Codecov Report

Merging #3450 (7316c0e) into master (8cfb07f) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #3450      +/-   ##
===========================================
- Coverage      4.81%   4.81%   -0.01%     
  Complexity      239     239              
===========================================
  Files           395     396       +1     
  Lines         35698   35710      +12     
  Branches       5553    5556       +3     
===========================================
  Hits           1720    1720              
- Misses        33727   33739      +12     
  Partials        251     251              
Impacted Files Coverage Δ Complexity Δ
...baba/otter/canal/common/utils/PropertiesUtils.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...al/connector/core/producer/AbstractMQProducer.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...l/connector/kafka/producer/CanalKafkaProducer.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ector/rabbitmq/consumer/CanalRabbitMQConsumer.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ector/rabbitmq/producer/CanalRabbitMQProducer.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ector/rocketmq/producer/CanalRocketMQProducer.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cfb07f...7316c0e. Read the comment docs.

@agapple agapple merged commit 32d9e58 into alibaba:master Apr 16, 2021
@agapple
Copy link
Member

agapple commented Apr 16, 2021

tks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants