Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] support json diff #1036

Merged
merged 5 commits into from Feb 11, 2023
Merged

Conversation

kaori-seasons
Copy link

What this PR does / why we need it?

support enhance jsondiff

Summary of your change

Please indicate you've done the following:

  • Made sure tests are passing and test coverage is added if needed.
  • Made sure commit message follow the rule of Conventional Commits specification.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed.

@CLAassistant
Copy link

CLAassistant commented Dec 26, 2022

CLA assistant check
All committers have signed the CLA.

@wenshao
Copy link
Member

wenshao commented Dec 29, 2022

请现在本地用mvn validate修复checkstyle相关问题

@wenshao wenshao added this to the 2.0.23 milestone Dec 30, 2022
@wenshao wenshao modified the milestones: 2.0.23, 2.0.24 Jan 14, 2023
@kaori-seasons
Copy link
Author

kaori-seasons commented Jan 27, 2023

@wenshao 我已经将fastjson_checks作为checkstyle插件的规则 本地formatter过 但是由此发现其他历史代码仍存在不符合检查规则的现象 . 有空麻烦approve下ci

@wenshao
Copy link
Member

wenshao commented Jan 30, 2023

testcase没跑过,是否可以把diff相关代码到extension中?

@kaori-seasons
Copy link
Author

kaori-seasons commented Feb 1, 2023

testcase没跑过,是否可以把diff相关代码到extension中?

checkstyle本地确实是没问题.... 我再看看 等修好之后可以迁移到extension

@wenshao
Copy link
Member

wenshao commented Feb 11, 2023

https://github.com/alibaba/fastjson2/tree/jsondiff
先合并到这个分支吧

@kaori-seasons
Copy link
Author

kaori-seasons commented Feb 11, 2023

https://github.com/alibaba/fastjson2/tree/jsondiff 先合并到这个分支吧

π__π 已经尽力了 validate的时候本地其他文件一直在报checkstyle error 2000多个... 我改下分支
432432

@wenshao
Copy link
Member

wenshao commented Feb 11, 2023

合并到这里,我来帮改,计划2月发的2.0.24版本估计来不及了,争取在下个月的2.0.25版本中加入吧

@kaori-seasons kaori-seasons changed the base branch from main to jsondiff February 11, 2023 05:52
@kaori-seasons
Copy link
Author

合并到这里,我来帮改,计划2月发的2.0.24版本估计来不及了,争取在下个月的2.0.25版本中加入吧

已经改了 非常感谢!

@wenshao wenshao merged commit 0f06e94 into alibaba:jsondiff Feb 11, 2023
@wenshao wenshao modified the milestones: 2.0.24, 2.0.25 Feb 11, 2023
@wenshao
Copy link
Member

wenshao commented Feb 25, 2023

diff/object/SimpleObjectExpect.json
diff/object/SimpleObjectActual.json

@complone 这两个文件是不是忘记提交了?

@wenshao wenshao modified the milestones: 2.0.25, 2.0.26 Mar 1, 2023
@wenshao wenshao modified the milestones: 2.0.26, 2.0.27 Mar 15, 2023
@wenshao wenshao modified the milestones: 2.0.27, 2.0.28 Mar 25, 2023
@wenshao wenshao modified the milestones: 2.0.28, 2.0.29 Apr 12, 2023
@yoyo-520
Copy link

这个功能预计啥时候发布哇 这个太实用了

@wenshao wenshao modified the milestones: 2.0.29, 2.0.30 Apr 21, 2023
@mymx2
Copy link

mymx2 commented Apr 28, 2023

String[] extInfo 都是空array时解析错误,二者期望结果应该一致。
另外,是否考虑添加一个action动作(missing,extra,different,inconsistent...),而不是把所有diff描述放在illustrate中。

json diff 错误

@wenshao wenshao modified the milestones: 2.0.30, 2.0.31 Apr 29, 2023
@wenshao wenshao modified the milestones: 2.0.31, 2.0.32, 2.0.33 May 7, 2023
@wenshao wenshao modified the milestones: 2.0.33, 2.0.x May 19, 2023
@yoyo-520
Copy link

yoyo-520 commented Jun 5, 2023

@wenshao @complone 麻烦问下各位老师这个JSON比对的功能还上嘛~

@ShiningXu
Copy link

希望JsonDiff可以支持 https://github.com/lukas-krecan/JsonUnit 项目的类似功能

@yoyo-520
Copy link

yoyo-520 commented Jul 5, 2023

@wenshao 这个功能还考虑增加吗?

@kaori-seasons
Copy link
Author

最近工作太忙了 KPI比较紧 可能一月份会有空推进。。。唉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants