Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix JSONReaderUTF8 nameValue1 for issue 2049 #2410

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

milabi
Copy link
Contributor

@milabi milabi commented Apr 8, 2024

fix(JSONReaderUTF8): 修复name的length=14位时,nameValue1计算

What this PR does / why we need it?

#2409

Summary of your change

map反序列化时,14位的key在对nameValue1计算有误,其第8位计算下标应为7,而不是8

Please indicate you've done the following:

  • Made sure tests are passing and test coverage is added if needed.
  • Made sure commit message follow the rule of Conventional Commits specification.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed.

@CLAassistant
Copy link

CLAassistant commented Apr 8, 2024

CLA assistant check
All committers have signed the CLA.

@wenshao
Copy link
Member

wenshao commented Apr 8, 2024

可以补充一个testcase么?

@milabi
Copy link
Contributor Author

milabi commented Apr 8, 2024

@wenshao 可以我稍后提交一下

@milabi
Copy link
Contributor Author

milabi commented Apr 8, 2024

可以补充一个testcase么?

已经补充了testcase,请问这个会在哪个版本中修复,大概会在什么时候发版?

@wenshao wenshao merged commit e7de4d7 into alibaba:main Apr 8, 2024
5 checks passed
@wenshao
Copy link
Member

wenshao commented Apr 9, 2024

https://oss.sonatype.org/content/repositories/snapshots/com/alibaba/fastjson2/fastjson2/2.0.49-SNAPSHOT/
2.0.49版本预计在4月下旬发布,可能是4月21日

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants