Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unstable test and nightly build #16

Merged
merged 2 commits into from
Oct 25, 2022
Merged

Fix unstable test and nightly build #16

merged 2 commits into from
Oct 25, 2022

Conversation

Sxnan
Copy link
Collaborator

@Sxnan Sxnan commented Oct 25, 2022

What is the purpose of the change

This PR fixes #12 and #10.

Brief change log

  • Add option to nightly build twine command to skip uploading wheel if the wheel already exists
  • Add the ".csv" suffix to the randomly generated filename to fix unstable test

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@Sxnan Sxnan requested a review from lindong28 October 25, 2022 07:22
@Sxnan Sxnan self-assigned this Oct 25, 2022
@lindong28
Copy link
Collaborator

Thanks for the PR! LGTM.

@lindong28 lindong28 merged commit 3e5c812 into alibaba:master Oct 25, 2022
@Sxnan Sxnan mentioned this pull request Oct 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lindong28 lindong28 Awaiting requested review from lindong28

Assignees

@Sxnan Sxnan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unstable unit test
2 participants
@Sxnan @lindong28