Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

修复 onPostPush 和 onPostPush 类型强转失败 #1707

Merged
merged 2 commits into from
Aug 30, 2022
Merged

修复 onPostPush 和 onPostPush 类型强转失败 #1707

merged 2 commits into from
Aug 30, 2022

Conversation

zmtzawqlp
Copy link
Contributor

@zmtzawqlp zmtzawqlp commented Aug 26, 2022 •
edited

onPostPush 和 onPostPush 中

  1. 用户 reslove 之后，不应该强转成 BoostInterceptorOption
  2. 用户 在方法中不调用 handler，应该也算是 终止

@CLAassistant
Copy link

CLAassistant commented Aug 26, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

@0xZOne
Copy link
Collaborator

0xZOne commented Aug 30, 2022

@zmtzawqlp 感谢贡献代码～～ 🙏 请将你的用户名加在 flutter_boost/blob/master/AUTHORS 文件中，谢谢。

@zmtzawqlp
Copy link
Contributor Author

@zmtzawqlp 感谢贡献代码～～ 🙏 请将你的用户名加在 flutter_boost/blob/master/AUTHORS 文件中，谢谢。

👌

@0xZOne 0xZOne merged commit 62b0249 into alibaba:master Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xZOne 0xZOne Awaiting requested review from 0xZOne

@kylinchen kylinchen Awaiting requested review from kylinchen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zmtzawqlp @CLAassistant @0xZOne