Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue): fix render loop cause by functional component in mapProps #3070

Merged
merged 2 commits into from Apr 25, 2022

Conversation

MisicDemone
Copy link
Collaborator

Before submitting a pull request, please make sure the following is done...

  • Ensure the pull request title and commit message follow the Commit Specific in English.
  • Fork the repo and create your branch from master or formily_next.
  • If you've added code that should be tested, add tests!
  • If you've changed APIs, update the documentation.
  • Ensure the test suite passes (npm test).
  • Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.

Please do not delete the above content


What have you changed?

fix #3034

@codecov
Copy link

codecov bot commented Apr 25, 2022

Codecov Report

Merging #3070 (518c4e5) into formily_next (43fbf03) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##           formily_next    #3070   +/-   ##
=============================================
  Coverage         96.06%   96.07%           
=============================================
  Files               149      149           
  Lines              6487     6494    +7     
  Branches           1750     1750           
=============================================
+ Hits               6232     6239    +7     
  Misses              255      255           
Impacted Files Coverage Δ
packages/vue/src/components/ReactiveField.ts 100.00% <100.00%> (ø)
packages/vue/src/shared/connect.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2128ae...518c4e5. Read the comment docs.

@janryWang janryWang merged commit 0d15fe9 into alibaba:formily_next Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] (designable=true)在ArrayField中动态添加VoidField时,发生渲染死循环
2 participants