Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(element): update type of IFormDialog #3360

Merged
merged 1 commit into from
Aug 31, 2022

Conversation

Zhhanou
Copy link
Contributor

@Zhhanou Zhhanou commented Aug 31, 2022

  1. 经检查下面的函数实现,IFormDialog中forConfirm、forCancel的参数middleware的类型IMiddleware泛型应为Form而不是IFormProps
  2. 更正对应的文档,并参照antd/FormDialog优化,使文档中的类型定义更清晰。

Before submitting a pull request, please make sure the following is done...

  • Ensure the pull request title and commit message follow the Commit Specific in English.
  • Fork the repo and create your branch from master or formily_next.
  • If you've added code that should be tested, add tests!
  • If you've changed APIs, update the documentation.
  • Ensure the test suite passes (npm test).
  • Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.

Please do not delete the above content


What have you changed?

1. 经检查下面的函数实现,IFormDialog中forConfirm、forCancel的参数middleware的类型IMiddleware泛型应为Form而不是IFormProps
2. 更正对应的文档,并参照antd/FormDialog优化,使文档中的类型定义更清晰。
@CLAassistant
Copy link

CLAassistant commented Aug 31, 2022

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Merging #3360 (fcc9041) into formily_next (867b166) will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           formily_next    #3360   +/-   ##
=============================================
  Coverage         96.16%   96.16%           
=============================================
  Files               152      152           
  Lines              6573     6573           
  Branches           1835     1835           
=============================================
  Hits               6321     6321           
  Misses              223      223           
  Partials             29       29           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@janryWang janryWang merged commit 9233d5e into alibaba:formily_next Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants