Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): indexes need exclude incomplete number #3437

Conversation

frehaiku
Copy link
Collaborator

@frehaiku frehaiku commented Oct 8, 2022

Before submitting a pull request, please make sure the following is done...

  • Ensure the pull request title and commit message follow the Commit Specific in English.
  • Fork the repo and create your branch from master or formily_next.
  • If you've added code that should be tested, add tests!
  • If you've changed APIs, update the documentation.
  • Ensure the test suite passes (npm test).
  • Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.

Please do not delete the above content


What have you changed?

修复 path 为 array.0.a2 时,index 属性取值为 NaN 的问题
https://codesandbox.io/s/mystifying-curran-s137rx?file=/src/App.vue

@codecov
Copy link

codecov bot commented Oct 8, 2022

Codecov Report

Base: 96.17% // Head: 96.17% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (74a42cb) compared to base (b3d3eb7).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff              @@
##           formily_next    #3437   +/-   ##
=============================================
  Coverage         96.17%   96.17%           
=============================================
  Files               152      152           
  Lines              6590     6593    +3     
  Branches           1840     1777   -63     
=============================================
+ Hits               6338     6341    +3     
- Misses              223      252   +29     
+ Partials             29        0   -29     
Impacted Files Coverage Δ
packages/core/src/models/BaseField.ts 100.00% <100.00%> (ø)
packages/antd/src/__builtins__/moment.ts 96.42% <0.00%> (-0.64%) ⬇️
packages/next/src/__builtins__/moment.ts 96.66% <0.00%> (-0.56%) ⬇️
packages/path/src/index.ts 65.25% <0.00%> (ø)
packages/path/src/parser.ts 92.42% <0.00%> (ø)
packages/path/src/shared.ts 50.87% <0.00%> (ø)
packages/vue/src/shared/h.ts 86.48% <0.00%> (ø)
packages/reactive/src/tree.ts 100.00% <0.00%> (ø)
packages/path/src/tokenizer.ts 91.74% <0.00%> (ø)
packages/reactive/src/array.ts 100.00% <0.00%> (ø)
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@janryWang janryWang merged commit d328bb3 into alibaba:formily_next Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants