Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): improve the translation and example of the login and registration case #3455

Merged
merged 1 commit into from Oct 13, 2022

Conversation

techbirds
Copy link
Contributor

@techbirds techbirds commented Oct 13, 2022

Before submitting a pull request, please make sure the following is done...

  • Ensure the pull request title and commit message follow the Commit Specific in English.
  • Fork the repo and create your branch from master or formily_next.
  • If you've added code that should be tested, add tests!
  • If you've changed APIs, update the documentation.
  • Ensure the test suite passes (npm test).
  • Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.

Please do not delete the above content


What have you changed?

  1. Improve the registration jsx example to add components about contacts

https://formilyjs.org/guide/scenes/login-register#pure-jsx-cases-1

image

  1. Improve the problem that some translations are out of sync, such as uploading components

https://formilyjs.org/guide/scenes/login-register#json-schema-cases-1

image

@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Base: 96.17% // Head: 96.17% // No change to project coverage 👍

Coverage data is based on head (945f8d9) compared to base (2c9b332).
Patch has no changes to coverable lines.

Additional details and impacted files
@@              Coverage Diff              @@
##           formily_next    #3455   +/-   ##
=============================================
  Coverage         96.17%   96.17%           
=============================================
  Files               152      152           
  Lines              6596     6596           
  Branches           1777     1777           
=============================================
  Hits               6344     6344           
  Misses              252      252           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@janryWang janryWang changed the title chore(docs): improve the translation and example of the login and reg… chore(docs): improve the translation and example of the login and registration case Oct 13, 2022
@janryWang janryWang merged commit 95c295b into alibaba:formily_next Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants