Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Any plan to sample with node attribute? #44

Closed
formath opened this issue May 13, 2020 · 3 comments
Closed

Any plan to sample with node attribute? #44

formath opened this issue May 13, 2020 · 3 comments
Labels
feature New feature or request

Comments

@formath
Copy link

formath commented May 13, 2020

An example

g.V("user").with_attribute("gender=man").batch(64).outV("buy").sample(2).with_attribute("city=1").by("random")
@baoleai baoleai added the feature New feature or request label May 13, 2020
Seventeen17 added a commit to Seventeen17/graph-learn that referenced this issue May 18, 2020
@Seventeen17
[fix alibaba#44] Fix memory leak.
f8aaded
jackonan added a commit that referenced this issue May 19, 2020
@jackonan
Merge pull request #46 from Seventeen17/master
890ed37 
[fix #44] Fix memory leak.
@Seventeen17 Seventeen17 pinned this issue May 19, 2020
@Seventeen17 Seventeen17 unpinned this issue May 19, 2020
@Seventeen17 Seventeen17 reopened this May 19, 2020
Seventeen17 added a commit that referenced this issue May 19, 2020
@Seventeen17
Revert "[fix #44] Fix memory leak."
b908215
@formath
Copy link
Author

formath commented May 19, 2020

@Seventeen17 Your pr is not relevant with this issue. Please change the link.

@Seventeen17
Copy link
Collaborator

@Seventeen17 Your pr is not relevant with this issue. Please change the link.

Sorry, I did it wrong, and I have reopened this issue. Let me figure it out with how to change the link.

@Seventeen17
Copy link
Collaborator

About this issue, we have't support a sample strategy with node attribute , you can implement this sampler following the guide: doc if you need it for recently, and welcome to contribution.

@formath formath closed this as completed May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@formath @Seventeen17 @baoleai