MultiPartitionMerger的counter merge存在bug

[yulei666]

havenask/aios/indexlib/indexlib/merger/multi_part_segment_directory.cpp

Line 153 in 9ed41ae

string MultiPartSegmentDirectory::GetLatestCounterMapContent() const

string MultiPartSegmentDirectory::GetLatestCounterMapContent() const
{
    if (mPartSegIds.empty())
    {
        return CounterMap::EMPTY_COUNTER_MAP_JSON;
    }

    CounterMap mergedCounterMap;
    for (const auto& segVec : mPartSegIds)
    {
        if (segVec.empty())
        {
            continue;
        }
        segmentid_t lastSegIdOfPartition = segVec.back();
        mergedCounterMap.Merge(
                GetCounterMapContent(mSegments.at(lastSegIdOfPartition)),
                CounterBase::FJT_MERGE);
    }
    return mergedCounterMap.ToJsonString();
}

这段Counter merge的代码有问题，merge出来State类型的counter会覆盖，所以deletedDocCount和partitionDocCount这两个counter的值是错误的。

{"__type__":"DIR","offline":{"__type__":"DIR","build":{"__type__":"DIR","addDocCount":{"__type__":"ACC","value":2000},"deleteDocCount":{"__type__":"ACC","value":0},"updateDocCount":{"__type__":"ACC","value":0}},"deletedDocCount":{"__type__":"STATE","value":0},"partitionDocCount":{"__type__":"STATE","value":1000}}

将两个partition合并，会出现这种情况，ACC了2000次，有2000个doc，但是partitionDocCount的值只有1000。

[foreverhy]

是的，多 partition 合并时，对于一些 state 类型的指标也应该累加。

[foreverhy]

@yulei666 有时间可以提交一个 pr 来 fix 一下么

[yulei666]

@yulei666 有时间可以提交一个 pr 来 fix 一下么

可以啊