optimize string decoding #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 19, 2021 10:32
Signed-off-by: wbpcode <comems@msn.com>
Signed-off-by: wbpcode <comems@msn.com>
Signed-off-by: wbpcode <comems@msn.com>
|
Some features of c++17 are used. Maybe we need to update the requested compiler version in README. |
zyfjeff
reviewed
Feb 21, 2021
|
|
||
| for (; i < out.size();) { | ||
| auto code = static_cast<uint8_t>(out[i]); | ||
| auto size = UTF_8_CHAR_LENGTHS[code >> 3]; |
There was a problem hiding this comment.
This is a nice optimization that improves performance by using shift operations and indexing operations instead of if and logical calculations.
Signed-off-by: wbpcode <comems@msn.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimized the decoding process for string. Reduced memory copy overhead by reading contiguous memory. Use branch-less method to determine the length of utf-8 strings.
Since a standard benchmark is missing, I can't determine the exact performance improvement.
However, from what I've seen in practice, it has reduced the string parsing overhead significantly.