Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using optional + ref as the return type of to* and supported heterogeneous lookup for string #20

Merged
merged 1 commit into from
Oct 9, 2022

Conversation

wbpcode
Copy link
Collaborator

@wbpcode wbpcode commented Oct 8, 2022

Signed-off-by: wangbaiping wbphub@live.com

…us lookup for string

Signed-off-by: wangbaiping <wbphub@live.com>
@codecov-commenter
Copy link

Codecov Report

Base: 85.98% // Head: 86.42% // Increases project coverage by +0.43% 🎉

Coverage data is based on head (b176576) compared to base (a60bf21).
Patch coverage: 81.48% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
+ Coverage   85.98%   86.42%   +0.43%     
==========================================
  Files          25       25              
  Lines        2269     2195      -74     
==========================================
- Hits         1951     1897      -54     
+ Misses        318      298      -20     
Impacted Files Coverage Δ
hessian2/object.hpp 76.95% <76.74%> (+0.81%) ⬆️
hessian2/basic_codec/class_instance_codec.cc 95.74% <100.00%> (-0.09%) ⬇️
hessian2/basic_codec/list_codec.cc 79.54% <100.00%> (-0.19%) ⬇️
hessian2/basic_codec/map_codec.cc 84.07% <100.00%> (-0.28%) ⬇️
hessian2/basic_codec/object_codec.cc 87.96% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wbpcode
Copy link
Collaborator Author

wbpcode commented Oct 9, 2022

Hi, @zyfjeff could you take a look when you have free time? Thanks.
This PR unified the return type of to* methods to optional ref wrapper.

And heterogeneous lookup for map with key type of StringObject is added. By this way, we can reduce unnecessary memory allocations when doing map search by raw string.

@zyfjeff
Copy link
Collaborator

zyfjeff commented Oct 9, 2022

reference: #3

@zyfjeff
Copy link
Collaborator

zyfjeff commented Oct 9, 2022

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants