opt: optimize redundant code #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Charlie17Li
requested review from
johnlanni,
SpecialYang,
Lynskylate and
gengleilei
as code owners
|
Could you add some UT for it？ |
ok |
johnlanni
requested changes
Dec 7, 2022
Charlie17Li
force-pushed
the
reactor/mcp
branch
2 times, most recently
from
80eb8df
to
44aab80
Compare
Signed-off-by: charlie <qianglin98@qq.com>
Signed-off-by: charlie <qianglin98@qq.com>
Signed-off-by: charlie <qianglin98@qq.com>
Signed-off-by: charlie <qianglin98@qq.com>
Signed-off-by: charlie <qianglin98@qq.com>
Charlie17Li
force-pushed
the
reactor/mcp
branch
from
312f988
to
59b7255
Compare
johnlanni
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: charlie qianglin98@qq.com
Ⅰ. Describe what this PR did
opt: optimize redundant code
Ⅱ. Does this pull request fix one issue?
fixes #91
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews