unit-test: increase coverage, path: pkg/ingress/kube/secret #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iutx
requested review from
johnlanni,
SpecialYang,
Lynskylate and
gengleilei
as code owners
|
get, i will rework for this pr later. |
johnlanni
requested changes
Jan 8, 2023
Signed-off-by: iutx <root@viper.run>
iutx
force-pushed
the
unit-test/ingress-kube-secret
branch
from
f8ee4af
to
55a34d2
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #105 +/- ##
==========================================
+ Coverage 26.09% 26.71% +0.62%
==========================================
Files 27 28 +1
Lines 4759 4772 +13
==========================================
+ Hits 1242 1275 +33
+ Misses 3438 3418 -20
Partials 79 79
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: iutx root@viper.run
Ⅰ. Describe what this PR did
increase coverage, path: pkg/ingress/kube/secret
0% -> 100%
Ⅱ. Does this pull request fix one issue?
fixes #87
Ⅲ. Why don't you add test cases (unit test/integration test)?
None
Ⅳ. Describe how to verify it
None
Ⅴ. Special notes for reviews
None