Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README translation of the hmac-auth plugin #306

Merged
merged 2 commits into from
Apr 27, 2023
Merged

Conversation

Fkbqf
Copy link
Contributor

@Fkbqf Fkbqf commented Apr 26, 2023

Ⅰ. Describe what this PR did

README translation of the hmac-auth plugin

Ⅱ. Does this pull request fix one issue?

fixes #72

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@Fkbqf Fkbqf requested a review from johnlanni as a code owner April 26, 2023 12:12
Copy link
Collaborator

@CH3CHO CH3CHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at inline comments

plugins/wasm-cpp/extensions/hmac_auth/README_EN.md Outdated Show resolved Hide resolved
plugins/wasm-cpp/extensions/hmac_auth/README_EN.md Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #306 (1876b9a) into main (4f16d6b) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #306   +/-   ##
=======================================
  Coverage   42.01%   42.01%           
=======================================
  Files          44       44           
  Lines        5850     5850           
=======================================
  Hits         2458     2458           
  Misses       3217     3217           
  Partials      175      175           

Copy link
Collaborator

@CH3CHO CH3CHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnlanni johnlanni merged commit 10d2b41 into alibaba:main Apr 27, 2023
7 checks passed
@Fkbqf Fkbqf deleted the dev branch April 27, 2023 11:13
@Fkbqf Fkbqf restored the dev branch April 27, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hmac-auth 插件的 README 文档翻译
4 participants