-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add profile/install/uninstall/upgrade command #538
Conversation
cc @Xunzhuo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Add missing licenses
- Make sure
make go.test.coverage
is passing before sending a PR.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #538 +/- ##
==========================================
- Coverage 39.99% 39.15% -0.84%
==========================================
Files 45 59 +14
Lines 6186 7776 +1590
==========================================
+ Hits 2474 3045 +571
- Misses 3539 4488 +949
- Partials 173 243 +70
|
2651a4c
to
4fc87e4
Compare
i've updated, please review again |
1f066b8
to
f35a4c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good, thanks for working on it and adding init support to hgctl, I do not want to block this for too long, so I would like leave a couple of follow-up tasks.
Improve UX
- opt install/uninstall/profile logs
- add logging animation/color
- support multi log-levels
Add waiting between components
- make sure components are running well.
Clean code
Ⅰ. Describe what this PR did
Add profile/install/uninstall/upgrade command
Ⅱ. Does this pull request fix one issue?
#229
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews