Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test cases for http2rpc #662

Merged
merged 1 commit into from Dec 9, 2023
Merged

Conversation

Hinsteny
Copy link
Collaborator

@Hinsteny Hinsteny commented Dec 2, 2023

Ⅰ. Describe what this PR did

just add test cases

Ⅱ. Does this pull request fix one issue?

NO

Ⅲ. Why don't you add test cases (unit test/integration test)?

yes

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

No

@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2023

Codecov Report

Merging #662 (850dac0) into main (a554ee1) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #662   +/-   ##
=======================================
  Coverage   35.63%   35.63%           
=======================================
  Files          73       73           
  Lines       10447    10447           
=======================================
  Hits         3723     3723           
  Misses       6438     6438           
  Partials      286      286           

@johnlanni
Copy link
Collaborator

@Hinsteny Please fix the e2e test.

@Xunzhuo Xunzhuo changed the title # Add test cases for http2rpc Add test cases for http2rpc Dec 6, 2023
@CLAassistant
Copy link

CLAassistant commented Dec 6, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@johnlanni johnlanni merged commit 4426f18 into alibaba:main Dec 9, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants