feat: add e2e test for envoy filter #710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjcsjc123
requested review from
Xunzhuo,
SpecialYang,
johnlanni and
Charlie17Li
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #710 +/- ##
==========================================
+ Coverage 34.05% 38.24% +4.18%
==========================================
Files 78 60 -18
Lines 11204 9979 -1225
==========================================
Hits 3816 3816
+ Misses 7096 5871 -1225
Partials 292 292
|
|
json文件如何添加license信息，这里testdata是移动过来的 |
|
@sjcsjc123 License check failed, please add copyright to these go files. |
johnlanni
reviewed
Dec 19, 2023
2456868764
reviewed
Dec 19, 2023
2456868764
reviewed
Dec 19, 2023
2456868764
reviewed
Dec 19, 2023
2456868764
reviewed
Dec 19, 2023
sjcsjc123
force-pushed
the
e2e-envoy-config
branch
from
1785a35
to
008a725
Compare
johnlanni
requested changes
Dec 21, 2023
johnlanni
requested changes
Dec 21, 2023
2456868764
reviewed
Dec 22, 2023
2456868764
reviewed
Dec 22, 2023
2456868764
reviewed
Dec 22, 2023
2456868764
reviewed
Dec 22, 2023
2456868764
reviewed
Dec 22, 2023
2456868764
reviewed
Dec 22, 2023
2456868764
reviewed
Dec 22, 2023
|
LGTM |
johnlanni
approved these changes
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
扩展e2e框架，使其支持envoy config的校验，并提供了make命令，可只执行envoy config相关的e2e测试
Ⅱ. Does this pull request fix one issue?
fixes: #703
Ⅲ. Why don't you add test cases (unit test/integration test)?
给出了configmap的tracing部分的e2e测试样例，执行
make higress-envoy-config-test可只运行envoy config相关的测试，本地测试已通过Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews